Skip to content

Conversation

@hujiatao0
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. labels Dec 8, 2025
@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Dec 8, 2025

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2025
@qiancai qiancai self-assigned this Dec 9, 2025
@qiancai qiancai changed the title add config for graceful shutdown v8.5.5: add config for graceful shutdown Dec 9, 2025
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Dec 10, 2025

### `graceful-shutdown-timeout`

+ graceful shutdown的超时时长,达到该时间后未完成转移的leader会跳过转移,节点直接进入停机流程。该值为0s时表示不启用graceful shutdown功能。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ graceful shutdown的超时时长,达到该时间后未完成转移的leader会跳过转移,节点直接进入停机流程。该值为0s时表示不启用graceful shutdown功能
+ TiKV 优雅关闭 (graceful shutdown) 的超时时长
+ 当该值大于 `0s` 时,如果关闭 TiKV 节点,TiKV 在该超时时间内会尽量将其上的 leader 副本转移到其他 TiKV 节点,然后再关闭。若达到该超时时间后仍有 leader 未完成转移,TiKV 将跳过剩余 leader 的转移,直接进入关闭流程。
+ 当该值为 `0s` 时,表示不启用 TiKV 的 graceful shutdown 功能。

Signed-off-by: hujiatao0 <[email protected]>
@qiancai qiancai changed the base branch from release-8.5 to feature/preview-v8.5.5 December 29, 2025 01:47
@qiancai
Copy link
Collaborator

qiancai commented Jan 13, 2026

The review of this PR was conducted in #21172.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-13 03:40:45.798903908 +0000 UTC m=+328889.860768817: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Jan 13, 2026

/approve

@qiancai qiancai added the lgtm label Jan 13, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 13, 2026
@ti-chi-bot ti-chi-bot bot merged commit 1ee718e into pingcap:feature/preview-v8.5.5 Jan 13, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants